Fixed crash in editor mode (log listener not being removed because destructors not being called. Base class destructors MUST be virtual!)

src/core/core.cpp

@@ -246,6 +246,7 @@ namespace lunarium
         return;
 #else
             mpRunMode = new editor::Editor;
+
             delete mPanels[gui::PanelType::PT_CORE_CONSOLE];
             mPanels[gui::PanelType::PT_CORE_CONSOLE] = nullptr;
             // Editor has it's own console

src/core/core_console.cpp

@@ -10,13 +10,19 @@
 #include <gui/dearimgui/imgui.h>
 #include <gui/dearimgui/imgui_internal.h>   // To use the DockWindowXXX methods
 
+#include <iostream>
+
 namespace lunarium
 {
     CoreConsole::CoreConsole()
         : Console(gui::PanelType::PT_CORE_CONSOLE, "Core Console"), mDockIsInit(false)
-        {
+    {
 
-        }
+    }
+
+    CoreConsole::~CoreConsole()
+    {
+    }
 
     bool CoreConsole::DoFrame()
     {

src/core/core_console.h

@@ -17,6 +17,7 @@ namespace lunarium
     {
         public:
             CoreConsole();
+            virtual ~CoreConsole();
             bool DoFrame() override;
 
         private:

src/internal_libs/gui/console.cpp

@@ -13,6 +13,7 @@
 #include <input/inputManager.h>
 #include <cstring>
 #include <sstream>
+#include <iostream>
 namespace lunarium
 {
     namespace gui
@@ -47,12 +48,20 @@ namespace lunarium
     Console::Console(PanelType type, const char* name)
         : Panel(type, name, gui::PanelDockZone::DDZ_NONE, false),
             mbNewCommand(false), mRecalledCommand(-1), mIsFocused(false), mListener(nullptr),
-            mbOglDebug(false), mbInfoVerbose(false)
+            mbOglDebug(false), mbInfoVerbose(false), mpListener(nullptr)
     {
         memset(mBuffer, 0, LUA_CON_BUFFER_SIZE);
-        Logger::GetInstance()->AddListener(new GuiListener(this));
+        mpListener = Logger::GetInstance()->AddListener(new GuiListener(this));
     }
 
+    Console::~Console()
+    {
+        Logger::GetInstance()->RemoveListener(mpListener);
+        delete mpListener;
+        mpListener = nullptr;
+    }
+
+
     bool Console::IsFocused() const
     {
         return mIsFocused;

src/internal_libs/gui/console.h

@@ -35,6 +35,7 @@ namespace lunarium
     {
     public:
         Console(PanelType type, const char* name);
+        virtual ~Console();
         virtual void Update(float dt);
         virtual bool DoFrame();
 
@@ -49,6 +50,7 @@ namespace lunarium
 
     private:
         // LUA COMMAND STUFF
+        LogListener* mpListener;
         char mBuffer[LUA_CON_BUFFER_SIZE];
         std::vector<std::string> mCommandHistory;
         bool mbNewCommand;

src/internal_libs/gui/panel.cpp

@@ -20,6 +20,11 @@ namespace gui
 
     }
 
+    Panel::~Panel()
+    {
+        
+    }
+
     PanelType Panel::GetType() const
     {
         return mType;

src/internal_libs/gui/panel.h

@@ -23,6 +23,7 @@ namespace gui
     {
     public:
         Panel(PanelType type, std::string name, PanelDockZone dock_zone, bool isOpen = false);
+        virtual ~Panel();
         PanelType GetType() const;
         const char* GetName() const;
 

src/run_modes/editor/panels/worldView.cpp

@@ -7,7 +7,7 @@
 ******************************************************************************/
 
 #include "worldView.h"
-#include <utils\logger.h>
+#include <utils/logger.h>
 #include <game/world/world.h>
 #include <gui/dearimgui/imgui.h>
 #include <editor/editor.h>

test_data/engine_state.xml

@@ -1,6 +1,6 @@
 <State>
     <DataDirectory>data/</DataDirectory>
-    <Mode Type="test" />
+    <Mode Type="editor" />
     <Display Renderer="opengl" IsFullScreen="false" VSyncEnabled="true">
         <FullScreenResolution Width="1920" Height="1080" />
         <WindowedSize Width="1280" Height="720" />